jasper
/
dmenu
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
584 Commits
2 Branches
0 Tags
1.1 MiB
C 83.4%
Roff 10%
Makefile 5.3%
C++ 0.7%
Shell 0.6%
 
 
 
 
 
develop
suckless/develop
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '41fdabbf7c'
${ noResults }
Go to file
NRK 41fdabbf7c drw_text: improve both performance and correctness 
this patch makes some non-trivial changes, which significantly improves
the performance of drawing large strings as well as fixes any issues
regarding the printing of the ellipsis when string gets truncated.

* performance:

before there were two O(n) loops, one which finds how long we can go
without changing font, and the second loop would (incorrectly) truncate
the string if it's too big.

this patch merges the overflow calculation into the first loop and exits
out when overflow is detected. when dumping lots of emojies into dmenu,
i see some noticeable startup time improvement:

before -> after
460ms  -> 360ms

input latency when scrolling up/down is also noticeably better and can
be tested with the following:

	for _ in $(seq 20); do
		cat /dev/urandom | base64 | tr -d '\n' | head -c 1000000
	echo
	done | ./dmenu -l 10

* correctness:

the previous version would incorrectly assumed single byte chars and
would overwrite them with '.' , this caused a whole bunch of obvious
problems, including the ellipsis not getting rendered if then font
changed.

in addition to exiting out when we detect overflow, this patch also
keeps track of the last x-position where the ellipsis would fit. if we
detect overflow, we simply make a recursing call to drw_text() at the
ellipsis_x position and overwrite what was there.

so now the ellipsis will always be printed properly, regardless of
weather the font changes or if the string is single byte char or not.

the idea of rendering the ellipsis on top incase of overflow was
from Bakkeby <bakkeby@gmail.com>, thanks! however the original patch had
some issues incorrectly truncating the prompt (-p flag) and cutting off
emojies. those have been fixed in here.
 		3 years ago
LICENSE bump version to 5.1 3 years ago
Makefile Makefile: just show the compiler output 7 years ago
README removed libdc dependence 14 years ago
arg.h arg.h: fixed argv checks order 9 years ago
config.def.h config.def.h: style improvement, use color Scheme enum 9 years ago
config.mk bump version to 5.1 3 years ago
dmenu.1 dmenu.1: document improved fastgrab behaviour from previous patch 6 years ago
dmenu.c remove false-positive warning for int comparison as bool 3 years ago
dmenu_path make dmenu_path script executable 6 years ago
dmenu_run dmenu_run: Split cache logic to dmenu_path again 13 years ago
drw.c drw_text: improve both performance and correctness 3 years ago
drw.h import new drw from libsl and minor fixes. 9 years ago
stest.1 applied Martin Kühl's inverse matching flag to stest 12 years ago
stest.c remove always true condition in if statement 4 years ago
util.c die() on calloc failure 8 years ago
util.h import new drw from libsl and minor fixes. 9 years ago

README 

dmenu - dynamic menu
====================
dmenu is an efficient dynamic menu for X.


Requirements
------------
In order to build dmenu you need the Xlib header files.


Installation
------------
Edit config.mk to match your local setup (dmenu is installed into
the /usr/local namespace by default).

Afterwards enter the following command to build and install dmenu
(if necessary as root):

    make clean install


Running dmenu
-------------
See the man page for details.